Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitlab_pipeline_schedule_variable resource #204

Merged
merged 4 commits into from
Nov 17, 2019
Merged

Add gitlab_pipeline_schedule_variable resource #204

merged 4 commits into from
Nov 17, 2019

Conversation

kirecek
Copy link
Contributor

@kirecek kirecek commented Oct 27, 2019

This PR adds a new resource gitlab_pipeline_schedule_variable.

proposed in issue: https://github.com/terraform-providers/terraform-provider-gitlab/issues/184

@roidelapluie
Copy link
Collaborator

Tests are failing

Signed-off-by: Erik Jankovič <erikjankovic@gmail.com>
Signed-off-by: Erik Jankovič <erikjankovic@gmail.com>
Signed-off-by: Erik Jankovič <erikjankovic@gmail.com>
Signed-off-by: Erik Jankovič <erikjankovic@gmail.com>
@kirecek
Copy link
Contributor Author

kirecek commented Nov 17, 2019

I'm sorry, can you be more specific about the failure? For me, tests passed even after rebase to master. I'm not sure what I am missing :(

@roidelapluie
Copy link
Collaborator

It passes now

@roidelapluie roidelapluie merged commit bd9ce78 into gitlabhq:master Nov 17, 2019
@kirecek kirecek deleted the add/r/gitlab_pipeline_schedule_variable branch November 17, 2019 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants